Toronto is beautiful city and finding great spots to take photos isn’t all that hard. For landscape, the Toronto Islands are a great place to shoot year-round, including for skyline photos. Bluffer’s Park in Scarborough has a dramatic cliffline. Toronto Islands offer some picturesque vantage points. You can take Toronto Skyline pictures by going down to the Cherry beach after dark or daytime.
CN Tower has great places inside that you can take skyline photos. It even has a glass floor that you can take photos while you are on top of the City.